comment tweak

got_repo_pack_fds_close: don't close(0) got_repo_pack_fds_close will try to close all of the GOT_PACK_NUM_TEMPFILES fds, even the ones that didn't manage to get a value from got_opentempfd(), which would result in a close(0) if we do not initialize to -1 here.

Correctly track if we sent more data since the last time we looked. With the narrow scope of bytes_sent_cur it would always be zero, and we would always update progress. Found by llvm's scan-build (Dead store). OK stsp

Prevent use-after-free of packed_refs_path in error path. Found by llvm's scan-build. OK stsp

Prevent memory leak when asprintf fails. Found by llvm's scan-build. OK stsp

Make sure got_repo_pack_fds_close() frees a malloc'ed pointer. Found by llvm's scan-build (bad free). OK stsp

If the first readdir() returns NULL err is uninitialized. This can't happen in practice, but llvm's scan-build doesn't know this. OK stsp

We don't care about the length of the read line. Found by llvm's scan-build (dead store). OK stsp

Do not ignore error from got_pathlist_append. Found by llvm's scan-build (dead store). OK stsp

Do not ignore error from format_author(). Found by llvm's scan-build (dead store). OK stsp

Dot not ignore error from got_object_id_str(). Found by llvm's scan-build (dead store). OK stsp

path_got is unused and never assigned, no need to free it OK stsp

Do not ignore I/O errors. Found by llvm's scan-build (dead store). OK stsp

Don't chug along if repo format version is unsupported. Found by llvm's scan-build (dead store). OK stsp

gotwebd: fix potential type mismatch between format specifier and argument ok tracey

tog: blame view keymap to open log of annotated line As per stsp's TODO item: open a log view of the selected line with 'L'. helped by and ok stsp@

regress: add missing return in error path

document pull request workflow in got.1 man page With permission from Jelmer Vernooij to use my pull request config for Dulwich, and Jelmer's name, as a real-life example. ok tracey, jamsek

typo in cat_commit otherwise prints the author instead of the committer

tog: alias J and K to > and < keybindings for diff view Use J and K to move to the next and previous commits, respectively, when the diff is loaded from the log or blame views. Patch by Mikhail ok stsp@

got commit: add flag to specify the author This adds a new flag, `got commit -A', that allows to specify the commit author but retains the "committer" (which is obtained as usual via GOT_AUTHOR, got.conf or git config.) with lots of help from and ok stsp

TODO: remove tog author/committer toggle entry

fix email address parsing we were both too strict and too lose. To avoid breaking got object parser (and to some extent ours too) we need to ensure that there aren't any line feeds, extra < or > and no trailing gibberish. The '@' is not actually required in the email. various tweaks and ok stsp

tog: add key to toggle author/committer in log view improvements and ok by jamsek and stsp

mark got_error_fmt as printf-like and fix the arisen errors ok stsp@