Commits
- Commit:
7e8fc9b50c3157452382726df908276e6db69ccd
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix documentation of gotwebd.conf default path
- Commit:
0b35d1c0ab442f6492a32167a305b34eb87bf9f7
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
bump version number
- Commit:
582843cdb37f9e50b3b0c6a348caee461d4f83c1
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
CHANGES for 0.75
- Commit:
4f0a80ed18c14d32968b403c50ce3e88e917da8f
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: fix briefs navigation broken in 4a9629420
got_get_repo_commits iterates over the commits and build a queue for
later display. My previous memleak fix moved the TAILQ_INSERT_TAIL
*before* the logic to exit the loop and so it broke the pagination.
This fixes it by delaying the insertion into the queue, but also by
moving the check for the "previous" button after we've opened the
commit.
ok tracey
- Commit:
8d02314fcaebb323c9ca3b102f8a085d66ea4633
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: percent-encode generated URLs
This adds a new helper function `gotweb_link' that outputs an HTML link
with the parameter correctly escaped.
ok stsp@
- Commit:
6e64c55881ec2855a3d5583227c02e4958db0ba9
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
sync distfile list
- Commit:
f864583e1f5425a3f135ee971b1445b4bc6c8b10
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: add missing closing for div tags_content
reported by the W3C validator.
- Commit:
8ee99f946108c3442fcc98fa53ecc9264ed5d947
- From:
- Omar Polo <op@omarpolo.com>
- Date:
free the return of got_repo_get_path_objects{,_pack}
- Commit:
58354f546a10c9449ba427873d047ef113c1693e
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: plug leak in got_output_repo_tree
- Commit:
93c74716961ac29893d89a1d807530c448a168b3
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: fix page title
due to an error in the order of the arguments to fcgi_printf that I've
introduced last time I touched gotweb_render_header the title is now
"/" (or SCRIPT_NAME) and one assets (the safari pinned tab svg) is a
funny URL :)
- Commit:
3264c09cde46f38f7530f9e07225846c916c020e
- From:
- Mark Jamsek <mark@jamsek.dev>
- Date:
tog: ensure stdin is a tty
This guards against {mis,ab}use such as `tog < /dev/null`.
ok plus fix from op@
- Commit:
7e0ec0529553d4a8e236cad41366f79eda5126b3
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: shrink struct server
keeping GOTWEBD_REPO_CACHESIZE * sizeof(struct cache_repo) inside the
struct server makes it too large for imsg on some platforms (linux at
least.) Instead, store a pointer and allocate the array when it's
received on the child processes.
ok stsp@
- Commit:
4cdd299d8c1d142b26efc3351dbab1c185f2c492
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: fix crash handling -D
Avoid crashing by corrupting the pointer instead of writing to it and
fix how sym is generated: it shouldn't include the '=' sign.
ok / improvement tb@
- Commit:
3d8e0c5ede1a5654397b63a9f483d875543527d5
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid a pointless malloc/free in got_reflist_insert() in my previous fix
suggested by op@
- Commit:
7db2b0ddc68d7d2761c2c1b93fa9543431efde97
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
detect packed vs. on-disk reference collision when listing refs
ok op@
- Commit:
e15c42decfa8a80fb91cc1e19b467efc34a8c05d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
plug leak in the commit graph iterator
We fail to release the memory for the nodes. To fix it however, we some
consumer of the commit graph iterator need to be corrected: the returned
pointer is safe to be used only up until the next iter_next call;
save a copy it if it's needed afterwards too.
ok stsp@
- Commit:
6227cf0ee49b322cc297ef95bdad09ea8eae2ec4
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotwebd: fix usage of the commit graph iter
got_get_repo_commits mixes ids allocated on the heap and the one
returned by the iter_next in the same variable, and then even attemp to
free it.
This is both a leak (we loose the pointer to the previously allocated
id) and a possible invalid free since the object id pointer returned by
the graph iterator is not to be passed to free(3).
part of a bigger diff that's ok stsp@
- Commit:
9ea55f08a2fdb3e7018231c9fe4014c758a0b69a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
add missing freaddrinfo
also spotted by valgrind. ok stsp@
- Commit:
54a0941e2bddd450b0797100b3218423b940f833
- From:
- Omar Polo <op@omarpolo.com>
- Date:
release the memory used by the object cache
Leak spotted by valgrind. ok stsp@
- Commit:
932b646a7df3d0578f831622f02348a768cb07bc
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
replace an indirect call to idset_add(), via add_node(), with a direct call
Avoids leaking the node structure returned from add_node().
ok op@
- Commit:
04666d1a54c25c8be7e39bc628b4a80f3376c127
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got: fflush(stdout) after asking questions
Not everywhere getline does an implicit fflush, so we might end up not
showing the prompt to the user. Spotted on alpine with muslc.
ok Thomas Adams
- Commit:
c877c437470e41e7f70828c916ff40189b097fe2
- From:
- Omar Polo <op@omarpolo.com>
- Date:
free commit on error path
while here drop the ternary too: if add_node succeeds `new_node' is
non-NULL. ok stsp@
- Commit:
85a99d1ea6ce4169303c521409e5527f69826641
- From:
- Omar Polo <op@omarpolo.com>
- Date:
plug leak: release nodes not added to the iter list
ok stsp@
- Commit:
9aae7366832613bbb94f56a2465380f5c2f56e7f
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got_commit_graph_close: free tailq contents
The tailq should ideally be empty when we reach got_commit_graph_close,
but consumer code may exit the commit graph loop earlier.
spotted by and ok stsp@
- Commit:
442ede73eadb025cdc45bede186bf31aee869dad
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
forbid rebase of references outside the refs/heads/ namespace
ok jrick