Commits


simplify gotd' timeouts string parsing no need to duplicate what strtonum does; pass the *real* maximum value allowed to it directly. ok stsp@


change gotweb_render_content_type argument type to const char * it's a string, `const char *' is fine (and what all the callers use anyway.)


gotwebd: use Content-Disposition for RSS; sets the filename Since gotwebd serves the RSS from a path without a file name component, browsers just make up a random string to give the file a name which can be confusing. Furthermore, since it's served as application/rss+xml they try to render the XML (failing.) Use gotweb_render_content_type_file (which sets the Content-Disposition HTTP header) to fix both: the feed is now called <repo-name>.rss and set as attachment (thus saved and not rendered.) Change the function to take an optional filename suffix for the occasion. ok jamsek


gotd: allow to express timeouts using minutes/hours This allows to use a suffix to indicate the unit of measure, such as "1h" for one hour or "30m" for 30 minutes. The suffix "s" for seconds is also accepted for completeness. ok stsp


enforce gotd request timeout > 0; the code doesn't handle zero right now spotted by + ok op@


gotwebd: tweak gotweb_render_content_type_file parameters type `type' and `file' are strings so use `const char *' for both.


add conf_limit_user_connection prototype at the top of parse.y different yacc implementations (e.g. GNU bison) may put the various parts in a different order, and so the definition of the function may not be visible in the generated code.


introduce connection options to gotd.conf Allow administrators to tweak the default authentication and request timeouts if needed, and to tweak the limit of concurrent connections for specific user accounts. with several tweaks from and ok op@


portable: __xpg_strerror_r: add forward-decl


portable: move tmpl.h to EXTRA_DIST This header isn't needed for direct compilation, but should be included as part of the main tarball.


portable: gotwebd: add tmpl.h to gotwebd_SOURCES unbreaks `make dist'


portable: template: don't install the binary template and its manpages it's only needed at build time to generate a source file.


portable: template: drop tmpl.c from SOURCES was added there mistakenly. it's not part of the "compiler", it's part of the "user library" and provides useful functions for the consumers. see also 1dec34dfda7ccb3caadab65aca907251ab8fd72e


make 'tog log' display the committer handle by default, '@' switches to author People coming from CVS might not expect names of patch contributers to show up in commit history listings, so make things easy for them. discussed with op@


log_warnx and fatalx prepend the program name internally, don't add it manually


gotd.conf: complain if a repository lacks a path in the configuration file


gotd.conf: treat empty repository names as a syntax error


gotd.conf: treat repositories without any parameters as a syntax error Because gotd expects some parameters to be present they must not be optional at the syntax level.


gotwebd: remove got_prefix in gotwebd.conf(5) example


fmt


adjust the first gotwebd.8 httpd.conf example to work out of the box gotwebd defaults to listening on a unix socket, and this man page aims to provide an appropriate configuration snippet in EXAMPLES. suggested by Paul Wrankin via gameoftrees IRC


fix previous; name must be initialized otherwise if binaryfilename fails to match the line, `name' may be left pointing to free'd memory.


got patch: handle the removal of binary files Diffs that remove binary files don't have hunks so got patch would skip over them, treating that part of the diff as "noise". Different programs outputs a slightly different diff for this kind of patches, but the "Binary files ... and /dev/null differ" is usually shown, so try to match it. The adedd regress test covers got diff, git diff, and OpenBSD' /usr/bin/diff. CVS diffs will currently fail because the guessed file name will be wrong. CVS prints the file name in the Index and RCS lines which got patch currently ignores, and shows an useless path in the "Binary files /tmp/cvs... and /dev/null differ" line. Discussed with and ok stsp@


gotwebd: print commit message too in gotweb_render_commits Regression from 156a1144 spotted by stsp, thanks!


gotwebd is a Web daemon