Commits
- Commit:
bdb6cb9b8b2633c831f532e05cb1780710cde9a8
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix gotd sometimes reading reused deltas from wrong pack file
The reuse-pack is pinned but may change its cache slot while objects
are being deltified. Refresh the pointer to the pinned reuse-pack before
writing out the pack file, ensuring that reused deltas will in fact be
read from the reuse-pack and not some other pack. Otherwise gotd may send
a broken pack file, or hit an ERR_RANGE condition if the pack file which
now occupies the pinned-pack's old cache slot is shorter. Which can trigger
attempts to read beyond end-of-file which show up in the logs like this:
gotd[37311]: repo_read /var/git/got.git: sending packfile: value out of range
gotd[43877]: uid 1002: value out of range
gotd[43877]: uid 1002: disconnecting
- Commit:
017d8b7bf9006ae1bc36f6b1a38978f2782b363f
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
properly initialize csum struct in write_packed_object()
fixes send.sh test fallout on arm64 and should also fix i386
ok op@
- Commit:
ae25a666dd4099105786ef32f1e6ebaf92abe64d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
add some helper functions to compute hashes
This adds a set of functions to abstract over SHA1Init, SHA1Update,
SHA1Final, their respective SHA256 variants and how to compare digests.
Replace all the SHA1*() usage with the new APIs. It's a preparatory
step for sha256 handling.
ok stsp@
- Commit:
5822e79e39a8777984e08b5d89a8c55d6aa0356d
- From:
- Omar Polo <op@omarpolo.com>
- Date:
include sha2.h too where sha1.h is included
In preparation for wide sha256 support; stsp@ agrees. Change done
mechanically with
find . -iname \*.[cy] -exec sam {} +
X ,x/<sha1\.h>/i/\n#include <sha2.h>
- Commit:
c7a4fcc8bebad9dc0bd1183fec3bd405dd4ebc57
- From:
- Omar Polo <op@omarpolo.com>
- Date:
gotadmin pack: add a -D flag to force using ref-delta
Intended mostly for the regress suite, so we'll be able to test also the
ref-delta code paths.
ok stsp@
- Commit:
24b7de1c04072bf25db2df8acbf93a7ba7bbabfd
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid copying reused deltas to delta cache file; copy from pack file instead
ok op@
- Commit:
13b2bc374c1870ec27b2eeb40efe68fd465f64bb
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
introduce gotd(8), a Git repository server reachable via ssh(1)
This is an initial barebones implementation which provides the absolute
minimum of functionality required to serve got(1) and git(1) clients.
Basic fetch/send functionality has been tested and seems to work here,
but this server is not yet expected to be stable.
More testing is welcome. See the man pages for setup instructions.
The current design uses one reader and one writer process per repository,
which will have to be extended to N readers and N writers in the future.
At startup, each process will chroot(2) into its assigned repository.
This works because gotd(8) can only be started as root, and will then
fork+exec, chroot, and privdrop.
At present the parent process runs with the following pledge(2) promises:
"stdio rpath wpath cpath proc getpw sendfd recvfd fattr flock unix unveil"
The parent is the only process able to modify the repository in a way
that becomes visible to Git clients. The parent uses unveil(2) to
restrict its view of the filesystem to /tmp and the repositories
listed in the configuration file gotd.conf(5).
Per-repository chroot(2) processes use "stdio rpath sendfd recvfd".
The writer defers to the parent for modifying references in the
repository to point at newly uploaded commits. The reader is fine
without such help, because Git repositories can be read without
having to create any lock-files.
gotd(8) requires a dedicated user ID, which should own repositories
on the filesystem, and a separate secondary group, which should not
have filesystem-level repository access, and must be allowed access
to the gotd(8) socket.
To obtain Git repository access, users must be members of this
secondary group, and must have their login shell set to gotsh(1).
gotsh(1) connects to the gotd(8) socket and speaks Git-protocol
towards the client on the other end of the SSH connection.
gotsh(1) is not an interactive command shell.
At present, authenticated clients are granted read/write access to
all repositories and all references (except for the "refs/got/" and
the "refs/remotes/" namespaces, which are already being protected
from modification).
While complicated access control mechanism are not a design goal,
making it possible to safely offer anonymous Git repository access
over ssh(1) is on the road map.
- Commit:
cae60ab8f2a261b006b3ccbded2d53dccbd6f300
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
let callers of got_pack_create() configure rate-limiting of progress reporting
Needed by future gotd(8), where progress reports will be sent to a network
socket, rather than a local terminal.
- Commit:
301e83b3580ad6750144e2e36393b74e6fd6adcb
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
move privsep code from pack_create.c into new file pack_create_privsep.c
Needed by future gotd(8).
ok op@
- Commit:
a32780aad7a4bc8539de9e7fd39b371f2fe8c346
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
move got_opentempfd() call out of got_pack_create()
Future gotd(8) needs to run got_pack_create() in a chroot environment,
so we can no longer open new temporary files inside got_pack_create().
ok op@
- Commit:
894e4711ffca9e21b24e567a610d387bd0c31817
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make got_pack_create() write to a file descriptor instead of a stdio FILE
The old code required a seekable output file. This conflicts with requirements
of future gotd(8), which will write pack file data to network sockets.
ok op@
- Commit:
5e91dae4dd43b8024731223110ab18f505f453ac
- From:
- Josiah Frentsos <jfrent@tilde.team>
- Via:
- Stefan Sperling <stsp@stsp.name>
- Date:
remove trailing whitespace; patch by Josiah Frentsos
- Commit:
756050ac401f1e724f0c1fd97af4a9855589c703
- From:
- Omar Polo <op@omarpolo.com>
- Date:
mark got_error_fmt as printf-like and fix the arisen errors
ok stsp@
- Commit:
61af9b215c06bece11deb27d941b390b81e0f8c6
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
implement support for commit coloring in got-read-pack for speed
ok op, tracey
- Commit:
58e31a80da4f4a9e10eaea148672190f35107a47
- From:
- Omar Polo <op@omarpolo.com>
- Date:
build with -Wwrite-strings
Throwing this into the mix for a while, we can always get rid of it
again if it becomes annoying. No objections from stsp@
- Commit:
3d589bee0bbbe812bb91f3b0284fbf2596304132
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
allow start_pack_privsep_child() to be called from outside lib/object.c
- Commit:
336075a42a5ae0fa322db734c481d21998e82bb8
- From:
- Omar Polo <op@omarpolo.com>
- Date:
build with -Wmissing-prototypes
ok stsp@
- Commit:
db9b9b1c2b70d98419e70b05e7283b2284bedbec
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
let got-read-pack be explicit about whether it could enumerate all objects
This allows the main process to avoid looping over all object IDs again
in case the pack file used for enumeration is complete.
ok op@
- Commit:
eb7b30a1caf056832bec7619ececf88efa18f6bd
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix error handling in find_pack_for_enumeration(); pointed out by op@
- Commit:
0ab4c95723904e176687f5edc131bdf422dd261a
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
Bring back object enumeration inside got-read-pack as a fast path.
The problem that was found in the earlier version has been fixed.
ok op@
- Commit:
e44d939152693c16e95d2855b539ad6b30e81b15
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
revert object enumeration in got-read-pack for now; needs more work
This implementation marked commits and trees as enumerated before all trees
which they depend on were enumerated. This behaviour leads to incomplete
pack files when a tree is only partially packed and got-read-pack hits
a missing tree entry as a result. The algorithm must be reworked such
that packed leave nodes are marked enumerated first, then bubble-up.
Found by op@
- Commit:
9f4f302a43f7e186910d59f9dbe0f839b6f2d565
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
free id and path in load_packed_tree_ids() on error, else they would leak
pointed out by op@
- Commit:
cee6a7ea556f9f3ae0f50df959c2acd8cb59bf80
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
implement object enumeration support in got-read-pack
ok op@
- Commit:
ce2bf7b7c9058374563c6db8608dbab9df2bba7d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix a bug in findwixt() which caused pack files with missing parent commits
The 'nskip' variable is supposed to reflect commits which are waiting on
the queue and have the 'skip' color. Only increment 'nskip' when adding
such commits to the queue.
Problem observed with got send -T and a tag pointing to a deleted branch.
Test to reproduce the bug written by op@.
- Commit:
d6a28ffe187127e3247254d7e242bb52d66eb26b
- From:
- Omar Polo <op@omarpolo.com>
- Date:
use random seeds for murmurhash2
change the three hardcoded seeds to fresh ones generated on demand via
arc4random. Suggested/fixed by and ok stsp@