Commits
- Commit:
ae30b714638faafc5075b3a69696149f4a129630
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
provide a getline-style function for blobs
ok jamsek
- Commit:
d4940d40064a4fd732c26af1bb551d1ff633852d
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
revoke filesystem access in gotd listen process via unveil(2)
This should avoid involuntary use of bind(2) with arbitrary socket paths.
ok op@
- Commit:
c8cf682107ebbe81da9db3dbd267c51ff151b049
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
expose 'gotctl info' output only to the root user
Now that anyone can connect to the socket, it is probably safer to
expose information about currently connected clients only to root.
- Commit:
bea82c4f04244e6cbe016b150601e00a7f26bfe8
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd.conf: use `listen on socket' syntax for UNIX sockets too
and drop unix_socket and unix_socket_path in server context.
ok stsp@
- Commit:
f2fc8ce0a3b225e5408c9b26476e395ca7109e63
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
remove the gotsh group requirement from gotd; any user can now connect
Repository access is now controlled by access rules in gotd.conf,
and concurrent connections to the gotd socket by local users are
limited by the listen process. We should keep refining our anti-DoS
measures in the future, but at least we have something in place now.
ok jamsek, op
- Commit:
efe3fd03c530b4b4e583a61d9106ffc560ba9bea
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: rework got_output_file_blob, no functional change
can now use got_object_blob_is_binary to simplify the logic.
ok stsp@
- Commit:
a5f70c45170231fc53fcfe00069abd2dc295b49c
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
add got_object_blob_is_binary function
needed for future use by gotwebd. ok stsp@
- Commit:
615f21afb47c7c32f95001b4dd3248a4ac6fc709
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotd.8: point people at gotsh.1 ssh restriction tips
- Commit:
8b4993fad59395b3e0cb9e272c88c2f62b33055e
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: remove erratic horizontal scrolling
In some pages gotwebd shows horizontal scrollbars because the error
message overflows the width.
Remove the explicit width in the CSS, the message is still rendered fine
and doesn't overflow the page.
spotted by and ok tracey@
- Commit:
85bccbf76e77e3f3f535f42d21d106ad54504758
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
simplify gotd' timeouts string parsing
no need to duplicate what strtonum does; pass the *real* maximum value
allowed to it directly.
ok stsp@
- Commit:
0cef9478411f528bc7f37b8c7a21d21a7f650592
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
change gotweb_render_content_type argument type to const char *
it's a string, `const char *' is fine (and what all the callers use
anyway.)
- Commit:
d7034a4ea257e654c3ac01eae64452461d31d233
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: use Content-Disposition for RSS; sets the filename
Since gotwebd serves the RSS from a path without a file name component,
browsers just make up a random string to give the file a name which can
be confusing. Furthermore, since it's served as application/rss+xml
they try to render the XML (failing.)
Use gotweb_render_content_type_file (which sets the Content-Disposition
HTTP header) to fix both: the feed is now called <repo-name>.rss and set
as attachment (thus saved and not rendered.) Change the function to
take an optional filename suffix for the occasion.
ok jamsek
- Commit:
77d755e8ee27002658ec8f9ed0a282ac89d2906f
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotd: allow to express timeouts using minutes/hours
This allows to use a suffix to indicate the unit of measure, such as
"1h" for one hour or "30m" for 30 minutes. The suffix "s" for seconds
is also accepted for completeness.
ok stsp
- Commit:
912db690abe419dd5f82d9ea6ecf351ab2c48f00
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
enforce gotd request timeout > 0; the code doesn't handle zero right now
spotted by + ok op@
- Commit:
c7c382950394eeda4875e2da6812e05c61a291d3
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: tweak gotweb_render_content_type_file parameters type
`type' and `file' are strings so use `const char *' for both.
- Commit:
67f822ee222a3d9a131449ec1c80c275ca122e1b
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
add conf_limit_user_connection prototype at the top of parse.y
different yacc implementations (e.g. GNU bison) may put the various
parts in a different order, and so the definition of the function may
not be visible in the generated code.
- Commit:
0781db0e2428460cdb0b48d3797899eede6afa44
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
introduce connection options to gotd.conf
Allow administrators to tweak the default authentication and request
timeouts if needed, and to tweak the limit of concurrent connections
for specific user accounts.
with several tweaks from and ok op@
- Commit:
04cea7985a0e2dffb33ec3162a46f90b5d8253d6
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: __xpg_strerror_r: add forward-decl
- Commit:
2ee1d31001feed71783d443b0c84e03edd5f4851
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: move tmpl.h to EXTRA_DIST
This header isn't needed for direct compilation, but should be included
as part of the main tarball.
- Commit:
5518bc7b0d88e0fc9551e96e18fa2f0e93747ccf
- From:
- Omar Polo <op@omarpolo.com>
- Date:
portable: gotwebd: add tmpl.h to gotwebd_SOURCES
unbreaks `make dist'
- Commit:
d2a5fcbb4ec0124558be0b186425e9271756d9ee
- From:
- Omar Polo <op@omarpolo.com>
- Date:
portable: template: don't install the binary template and its manpages
it's only needed at build time to generate a source file.
- Commit:
a759b903cca3f0fcf20dba5c697849e21cdd9062
- From:
- Omar Polo <op@omarpolo.com>
- Date:
portable: template: drop tmpl.c from SOURCES
was added there mistakenly. it's not part of the "compiler", it's part
of the "user library" and provides useful functions for the consumers.
see also 1dec34dfda7ccb3caadab65aca907251ab8fd72e
- Commit:
8eca0bdb19386799f23e248e19627d62eeb65c50
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
make 'tog log' display the committer handle by default, '@' switches to author
People coming from CVS might not expect names of patch contributers to
show up in commit history listings, so make things easy for them.
discussed with op@
- Commit:
0cbf8de725393d7866ab0e146671a1611644afc6
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
log_warnx and fatalx prepend the program name internally, don't add it manually
- Commit:
88f1bb6ddf803e7ceb1f2f7a72253a46d12ae6c6
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotd.conf: complain if a repository lacks a path in the configuration file