Commits
- Commit:
7477a2d224dbe68e95d9ad64f112f81bb5a98ab6
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
plug line_offsets leak in tog blame view; ok op@
- Commit:
9403b6951f2a118360a5dc2f49b107ffce74d2e3
- From:
- Mikhail <mp39590@gmail.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: don't show the base commit marker in limit view
The limit commit queue is invariably filled with different commits to the
queue containing all commits, so the index of the work tree's base commit in
the real queue corresponds to a different commit in the limit queue. As such,
the marker is drawn on an incorrect commit. Rather than fix this to draw the
marker on the correct commit if it happens to be in the limit queue, don't
draw the marker at all in limit view. As pointed out by Mikhail on the list,
this information is not wanted in the limit view. Patch and report by Mikhail.
- Commit:
49dff0bd5f1fb112f762312d655dc99d24358c7c
- From:
- Mikhail <mp39590@gmail.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: fix log view search infinite loop
When the current matched and selected entry is the last loaded commit,
we keep looping the same code path because search_entry is always NULL.
Before poking the log thread for more commits, set search_entry to the
currently selected commit, which is where the search resumes.
Patch by Mikhail
- Commit:
3a333429726b35ea339647d2b857047a8a1998e5
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix occasional test failure in test_log_show_base_commit
Patch by jamsek with a request to commit. Thanks!
- Commit:
e2a79cf900ad48826685edea49a88c8f72d2e75f
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
prevent ncurses signal handlers from being installed while using mock-io
Aborting tog regress with Ctrl-C would trigger a "tty" pledge violation
via the built-in ncurses handler for SIGINT, installed by newterm().
Install tog's own signal handlers earlier to fix this.
- Commit:
6ebb22635171b6f1ad080fe10bf7b13133312957
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
add cancellation support to the mixed-commits checker in worktree.c
- Commit:
92845f0980b93eaf2ac1688899791f74af66a521
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
load tog's worktree base commit marker in the log thread for startup speed
Walking the whole file index can take some time. Avoid delaying the perceived
start-up time of tog by reading the file index in the background log thread.
Problem pointed out by op@
with fixes from + ok jamsek
- Commit:
f517f81a73a9457b33ef2da2f67f87e7ea95924c
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: change base commit marker to the commit colour
The marker annotates the commit, so it makes more sense to visually tie it
to the log message than the author. Patch by stsp, I just removed a block.
ok stsp@
- Commit:
5a5defb7f6bd8e14034b3cb70b3fadb7db246a77
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: plug leak in cmd_log() error path
ok op@
- Commit:
349dfd1ee9fe854ee194e3c9c46c494e932a7d00
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: show work tree base commit marker in log view
If tog is invoked in a work tree, prefix the base commit log message summary
line with a '*' if the work tree is up-to-date, and with a '~' if the base
commit is not up-to-date with respect to the branch tip or it contains mixed
commits. While here, plug a couple worktree leaks in cmd_ref() and cmd_tree().
ok stsp@
- Commit:
66b04f8f59f931fc5e30d76b7a9032f336ec5556
- From:
- Mark Jamsek <mark@jamsek.dev>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: add support for commit keywords
Allow keywords as arguments to options and operands for the blame, diff, log,
and tree commands. Also, return 1 when exiting tog with error rather than 0
so regress can discern success from failure.
ok stsp@
- Commit:
ad10f64ebeae9e8625205b8ef468ce58e03db95b
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
use a separate .cvg meta data directory for cvg(1) work trees
This prevents mixing the use of got and cvg clients in the same work tree.
Avoids confusion going forward while cvg differentiates itself further.
tog(1) and gotadmin(1) remain compatible with both work tree formats.
These tools only read work trees to locate the corresponding repository.
- Commit:
c68571e2c407e42a8da06182caf11ae7c49b509e
- From:
- Josiah Frentsos <jfrent@tilde.team>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: fix double-free in blame view error path
open_diff_view() has already called view_close() on error.
Patch by Josiah Frentsos.
- Commit:
cbb35faca2dd0bef98f640a9a0a87ca48c429454
- From:
- Tracey Emery <tracey@traceyemery.net>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
Fix for cc1: warnings being treated as errors
/home/got/src/got/tog/tog.c: In function 'draw_tree_entries':
/home/got/src/got/tog/tog.c:7307: warning: comparisons like X<=3DY<=3DZ do =
not have their mathematical meaning
- Commit:
9e26f05792286fa1ff16e43516f1f4a688b672b9
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
avoid strlen in for(;;)
ok jamsek, stsp
- Commit:
081e3dc235439cbb3e34342349768119ddf4ad49
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
got, tog: correctly skip HEAD in build_refs_str()
s[strlen(s)] == '\0' is banally always true, the intent was to not skip
refs that starts with "HEAD".
style nit / ok stsp@
- Commit:
00580e07010e9d6aab00f67b628381ca81f19def
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix refs_str memory leaks
Pointed out by op@
- Commit:
cabb4cfd832114dd19f9e48a7640a7527dc4f755
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
rework how reference labels are rendered in the tog log view
Draw reference labels and log message as separate strings. The previous
code contained calculations mixing variables which represent an amount
of wide characters in a string vs the display width of the string. We
can avoid such nonsense by keeping the strings separate, though we have
to be a bit careful about keeping horizontal scrolling intact.
Also fix a bug where we failed to account for reference labels while
setting view->maxx which made the $ key not scroll far enough.
ok op@
- Commit:
201812127e27ef2aa4827752e229d8f5251f6ff6
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
typo: character -> characters
- Commit:
0d095295f9c0504bf7b11611b530becd27f34ee1
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
stop showing backup references in the tog log and diff views
Backup references clutter the log view too much now that we display
labels next to commit messages.
They were accidentally added to the log and diffs view by me, via
build_refs_str(), when support for listing backup references was
added to the ref view.
- Commit:
fcfb26c37e218d01b0cfb8b960b7b186f9ee285e
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix 'tog log' display regression with long reference lists
When the terminal becomes smaller horizontally we did not properly
account for remaining columns and the log message of a commit could
overflow into the next line, garbling the display.
- Commit:
00ddec2f20c1ce1b0136a7ae54efb790069126ec
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
relax build_refs_str to allow a NULL reflist, simplifes the callers
ok stsp@
- Commit:
61dc16bb64b935a7b13342b8bc47db282d10e676
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
tog: fix segfault in draw_commit
build_refs_str() can succeed returning a NULL string if a commit
has some refs pointing to it but that were all filtered out, resulting
in a NULL-deref.
ok stsp@
- Commit:
f292b27176775cc4061f3da0be7fe0efcaf0325c
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
simplify previous; avoid temporary string
blind ok stsp@
- Commit:
9472af9550ec85323ab6c004d71f8a671a6b014d
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
show reference labels next to commit messages in tog log view
requested by mpi@
ok op@