Commits


CHANGES for 0.106


in gotd, use a polling loop around imsgbuf_write() instead of imsgbuf_flush() Avoids potential endless loops with non-blocking I/O.


fix wrong function name in error message


set GOT_NOTIFY_TIMEOUT to a more reasonable value to prevent test failures


prevent gotd from exiting with pending notifications if client disconnects


connect the notifier only if the session process is writing to the repo fixes "gotd: unexpected imsg 40" in logs


use GOT_NOTIFY_TIMEOUT for both notification helpers Fixes timeout setting used by http notification helper during tests.


add a missing allow_fdpass(); fixes serving of writes in gotd


use imsgbuf_flush instead of imsgbuf_write; fixes end-of-file errors


return an error instead of calling abort()


remove dangling include statement


convert got to new imsg API; build now requires OpenBSD -current Patch by op@, committing on his behalf and will be adding fixes on top


remove got_pathlist_append() Remove got_pathlist_append(). This leaves got_pathlist_insert() to add items to a pathlist, making it very easy to swap got_pathlist from a TAILQ to a RB_TREE. Patch by Kyle Ackerman


gotwebd: improve performance of repository age calculations Instead of sorting refs by name and then hunting for the youngest commits in that list, obtain an appropriately sorted list via got_ref_cmp_by_commit_timestamp_descending and then pick the first ref from this list. And in the case were we already know which ref to check, just open this ref directly instead of listing all the refs. Easier to read and should improve performance in both cases. ok op, jamsek


remove unused imsgbuf ok jamsek, stsp


gotwebd: ensure child procs inherit non-default config If a non-default config filepath is specified with -f, it is effectively ignored as child processes always either parse the default config file (/etc/gotwebd.conf) if it exists, or use defaults. Options specified in the config file used by server procs (e.g., chroot, user) are ignored. If -f is used with a non-default config file, pass it to child procs. ok stsp@


fix bogus "reference not found" error from 'got send' When a reference exists on the server but not locally, 'got send' could fail to ignore this reference as intended, raising an error instead. Add a test case for this isssue.


fix a typo in CHANGES, spotted by teajaygray@rap.social


bump version number


CHANGES for 0.105


whitespace


plug memory leaks in 'got fetch' and 'got send' In addition to the previous commit [c450903bc2] that plugged fetch and send leaks, free what would be the path entry's path member, which is leaked when attempting to add a duplicate. And in the fetch case, free refname and id when got_pathlist_insert() returns err. ok stsp@


make gotwebd.css styling consistent across all window sizes Patch by op@, who is at the wrong computer right now


slight code simplification, seeing that clear_meta(NULL) is fine


plug a memory leak in got_pack_create() Patch by: Kyle Ackerman