Commits


Do not ignore error from format_author(). Found by llvm's scan-build (dead store). OK stsp


Dot not ignore error from got_object_id_str(). Found by llvm's scan-build (dead store). OK stsp


path_got is unused and never assigned, no need to free it OK stsp


Do not ignore I/O errors. Found by llvm's scan-build (dead store). OK stsp


Don't chug along if repo format version is unsupported. Found by llvm's scan-build (dead store). OK stsp


gotwebd: fix potential type mismatch between format specifier and argument ok tracey


tog: blame view keymap to open log of annotated line As per stsp's TODO item: open a log view of the selected line with 'L'. helped by and ok stsp@


regress: add missing return in error path


document pull request workflow in got.1 man page With permission from Jelmer Vernooij to use my pull request config for Dulwich, and Jelmer's name, as a real-life example. ok tracey, jamsek


typo in cat_commit otherwise prints the author instead of the committer


tog: alias J and K to > and < keybindings for diff view Use J and K to move to the next and previous commits, respectively, when the diff is loaded from the log or blame views. Patch by Mikhail ok stsp@


got commit: add flag to specify the author This adds a new flag, `got commit -A', that allows to specify the commit author but retains the "committer" (which is obtained as usual via GOT_AUTHOR, got.conf or git config.) with lots of help from and ok stsp


portable: remove imsg.h Allow imsg.h to be checked for portably.


TODO: remove tog author/committer toggle entry


fix email address parsing we were both too strict and too lose. To avoid breaking got object parser (and to some extent ours too) we need to ensure that there aren't any line feeds, extra < or > and no trailing gibberish. The '@' is not actually required in the email. various tweaks and ok stsp


tog: add key to toggle author/committer in log view improvements and ok by jamsek and stsp


mark got_error_fmt as printf-like and fix the arisen errors ok stsp@


portable: README: mention shortlog format When writing -portable patches, mention the format of the commit's shortlog.


portable: update gitignore for gotwebd Add gotwebd and parse.c which are compiled/generated and should not be tracked.


add another TODO idea for tog


tog: always request commits if log height is increased Includes style improvements prompted by stsp. Previously, we would only call request_log_commits() when terminal height is increased in a splitscreen view. This fixes the case when a log view with no children is resized that can lead to empty lines: $ tog # 80x24 23j # move down to the last commit *increase terminal height to ~30 lines then reduce back to 80x24* ~5j # move down to the _last_ commit *increase terminal height to ~33 lines* *new lines are empty* ok stsp@


TODO: add cherrypick/backout immediate-commit-mode idea


write down some ideas about author/committer handling in TODO


add more information to the HTTP TODO item


add more TODO items for tog