Commits
- Commit:
f8174ca59ba426ea9c475fd15d2db770f8595b5e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
store a path hash instead of a verbatim path in pack meta data
This reduces memory use by gotadmin pack. The goal is to sort files
which share a path next to each other for deltification. A hash of
the path is good enough for this purpose and consumes less memory
than a verbatim copy of the path. Git does something similar.
ok op@
- Commit:
3e6ceea0bd8a65737eb2231ce18d0e591dfb92ff
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix paths stored in pack meta data, improving file deltification
The old code was broken and stored an empty path or filenames, instead
of a repository-relative path. Which means we didn't sort files for
deltification as was intended.
Fixing this provides much better deltas in large pack files written by
gotadmin pack -a. In my test case, pack size changed from 2GB to 1.5GB.
ok op@
- Commit:
17259bfa94068499f61aec3129c47ae2671bd531
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
plug a small memleak on error in got_pack_create()
- Commit:
e1f5d7cf67ae80171a7360796fb87c328f22cff3
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid malloc/free for duplicate check in got_pathlists_insert()
ok op@
- Commit:
c9b75c7bd7036a6895bbc3eba2ed0369238ebab4
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
revert "Skip poll(2) if an imsgbuf has a non-empty read buffer"
imsg_read() will call recvmsg() on the file descriptor regardless
of the read buffer's state, so we should ensure that data is ready.
The read buffer is used by imsg_get(), not imsg_read().
We already call imsg_get() before imsg_read(), and call the latter
only if imsg_get() returns zero.
- Commit:
2ab714554f1fd2273c9705450cf192dabb4f6b9d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
Skip poll(2) if an imsgbuf has a non-empty read buffer.
- Commit:
1453347d2463ce1b2700dd9fa810f30f2a443e5e
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
imsg_add() frees its msg argument on error; avoid double-free in error paths
- Commit:
33fd69c2e53ffe1f0a7e1184293f6918a377376d
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
batch up tree entries in imsg instead of sending one imsg per tree entry
This speeds up loading of trees significantly.
ok op@
- Commit:
9985f404ff5dc911b6186e5fa6233fa36848a19a
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
parse tree entries into an array instead of a pathlist
Avoids some extra malloc/free in a performance-critical path.
ok op@
- Commit:
3483a4da364d64c5b630cec74a97fab5b5035c65
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
prevent an out-of-bounds access in got_privsep_recv_tree()
- Commit:
baef4d750d80fcf0fddce409470150e73ae120d3
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
plug memory leak in an error path of got_privsep_recv_tree()
- Commit:
13fcf1bf305bb86f5bbe5da661f8811846b79d61
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
make got_privsep_recv_tree() reject trees with less than zero entries
- Commit:
7429ae85e5dff2953bced09c774ea43f501e8929
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
rework logic in got_privsep_recv_tree() to avoid an ugly 'goto'
no functional change
- Commit:
4bcdc8959af14bcb2e50c7f303df6c055573bc7a
- From:
- Omar Polo <op@omarpolo.com>
- Date:
refactor got_patch / got_worktree_patch_complete
let got_patch own fileindex_path and call got_worktree_patch_complete
only if got_wokrtree_patch_prepare hasn't failed.
suggested by stsp@
- Commit:
f2dd780737c47f6d92e6fe01cbd51bf93c91b3b3
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got patch: avoid open/sync/close the fileindex over and over again
Instead of flushing the fileindex after every patch in the patchfile
just reuse the same fileindex and sync it only at the end of the patch
operation. This speeds up 'got patch' on large repositories by quite a
lot.
- Commit:
e45f7eba7c3fe929b6bd5852f390301aeace98aa
- From:
- Christian Weisgerber <naddy@mips.inka.de>
- Date:
got patch: switch from fseek() to fseeko(), use unary minus while here
ok op
- Commit:
be33dff7fa389c620154dc06efbeae69bd002950
- From:
- Omar Polo <op@omarpolo.com>
- Date:
got patch: fail when reading empty hunks
- Commit:
6d9c73d72e43db5dfe560cade0a61eed638b45d0
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
bump version number
- Commit:
1dc7dca25f4bd1f501d925a5397236745c8c79f4
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
CHANGES for 0.70
- Commit:
e93fb944fe7b32d96fafd4726043a28062563b54
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
map delta cache file into memory if possible while writing a pack file
with a fix from + ok op@
- Commit:
dc3fe1bf10950c200037f0198f2445ea176f8cc3
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
fix load_object_ids() such that packing tags works if zero commits are packed
reported by jrick and op
- Commit:
cab5dc8bbeefffc8a4319ec0788b472e1084a564
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
hook cmdline send tests up for 'make regress', this was forgotten
- Commit:
fae7e03842e8618973f4d4910a86a52d881ab2ab
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
run the search for deltas to reuse in got-read-pack
This significantly speeds up the deltification step of packing by
avoiding imsg traffic. gotadmin no longer requests individual raw
deltas from got-read-pack to check whether it can reuse them.
Instead, got-read-pack obtains a list of objects we want to pack,
and hands back the list of all deltas in its pack file which can be
reused. Messages are now batched such that imsg buffers are filled
as much as possible.
Another advantage is that deltas we are not going to reuse will
no longer be written to the delta cache file, saving disk space.
Before this patch, any raw delta candidate was written to the
delta cache file by got-read-pack, and the decision whether to
reuse the delta happened afterwards in the gotadmin process.
Code for reading individual raw deltas is now unused and could be
removed at some point.
ok op@
- Commit:
2f8438b006e9015401b93f55cea57b36b021ce56
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid 'remove unused' loop by storing excluded objects in a separate set
ok op@
- Commit:
f5e78e05ae4eb8c5e5909841ee696fa5b6d0dfea
- From:
- Stefan Sperling <stsp@stsp.name>
- Date:
avoid loop over the ID set which removes objects IDs with reused deltas
ok op@