revert object enumeration in got-read-pack for now; needs more work This implementation marked commits and trees as enumerated before all trees which they depend on were enumerated. This behaviour leads to incomplete pack files when a tree is only partially packed and got-read-pack hits a missing tree entry as a result. The algorithm must be reworked such that packed leave nodes are marked enumerated first, then bubble-up. Found by op@

in enumeration_request(), use the correct index for tagged commit objects Fixes an error where got-read-pack errors out with "bad object data" during 'got send' because we ended up handing a tag object to the commit object parser.

free id and path in load_packed_tree_ids() on error, else they would leak pointed out by op@

fix wrong line wrap; pointed out by op@

imsg_add() already frees wbuf on error; pointed out by op@

implement object enumeration support in got-read-pack ok op@

got stage: implicitly unstage when staging the reverse of the staged diff otherwise we end up with a staged empty edit for that file. ok stsp@

check the maximum cached delta size against the correct constant

convert delta cache to a hash table This approach uses more memory but is much faster. To offset the additional memory usage somewhat the cache now stores very small deltas only. However, overall memory usage goes up. Hopefully we will find a way to reduce this later. ok op@

set `ret' in a few places where it was forgotten; ok tracey@

don't pass $ret to test_done on failure when it's known to be zero Otherwise the test directory it's not left in place; ok tracey@

properly swap cached struct pack array elements in got_repo_cache_pack() Avoids clobbering open files for delta base/accumulation, leaking file descriptors, and triggering errors from close(2) during got_repo_close() as we try to close the same file descriptor more than once.

move creation of tempfiles outside of lib/diff.c ok tracey

map delta cache file into memory if possible while writing a pack file with a fix from + ok op@

portable: fix-up sha1.h include -portable doesn't need this directly.

tog: override SIGTERM and SIGINT handlers to avoid ncurses cleanup() handler ok thomas

reduce GOT_PACK_CACHE_SIZE to 32, otherwise it uses too many open files found by tracey

ensure that all open basefd/accumfd get closed in got_repo_close() found by tracey

open temporary files needed for delta application in got_repo_open() This prepares for callers of got_repo_open() that cannot afford to open files in /tmp, such as gotwebd. In a follow-up change, we could ask such callers to pass in the required amount of open temporary files. One consequence is that got_repo_open() now requires the "cpath" pledge promise. Add the "cpath" promise to affected callers and remove it once the repository has been opened. ok tracey

avoid get_delta_chain_max_size() in dump_delta_chain_to_mem()

avoid get_delta_chain_max_size() in dump_delta_chain_to_file()

fix a bug in findwixt() which caused pack files with missing parent commits The 'nskip' variable is supposed to reflect commits which are waiting on the queue and have the 'skip' color. Only increment 'nskip' when adding such commits to the queue. Problem observed with got send -T and a tag pointing to a deleted branch. Test to reproduce the bug written by op@.

use random seeds for murmurhash2 change the three hardcoded seeds to fresh ones generated on demand via arc4random. Suggested/fixed by and ok stsp@

include header

shrink struct got_pack_meta a bit by removing the have_reused_delta flag This flag can be expressed as m->reused_delta_offset != 0 because all deltas in valid pack files will be written at a non-zero offset. We allocate a huge number of these structs during packing, so every little bit helps.