Commits


add -J option to usage() function of relevant commands


make 'cvg commit' actually apply the -J option


regress/gotwebd: implement paginated commits test; ok op@


try to improve http-server startup/teardown in regress Let tests fail if http-server fails to start up within 5 seconds. Make http-server report its process ID in its log file such that tests can kill it by PID. Prompted by semi-regular failures on my arm64 regress builder.


use got_object_id_queue_free() instead of hand-rolled code ok stsp@


tog: don't apply count modifier to the H, &, p keymaps It's annoying to have the help (H) and limit (&) keymaps repeatedly fire after closing their respective views if accidentally preceded by a count modifier, and doesn't seem like a valid use case. Similarly, writing N patch files to /tmp is wasteful. ok stsp@


portable: update libutil to 1.38


portable: set next version


portable: release 0.107


portable: cvg add got_compat.h Needed to compile most things on -portable.


check for errors from telldir(3); suggested by jamsek


make 'got import' output independent of readdir(3) entry order ok jamsek


add a TODO item for 'gotadmin cleanup'


make seq(1) invocations in test_log_commit_keywords() portable The OpenBSD version of seq defaults to an increment value of -1 here. On Debian we have to set the increment value to -1 explicitly. Otherwise, seq produces no output at all and the test fails.


add more info about the test suite to README.portable Prompted by questions from Johannes Kastl.


portable: remove portably-defined headers These has to be looked for portably. <sys/tree.h> recently reappeared due to TAILQ -> RB_* changes upstream.


portable: define HAVE_TREE_H if libbsd found When using libbsd, ensure that we define HAVE_TREE_H; this means libbsd's <sys/tree.h> is used over the compat version which stops redefinition warnings from libbsd.


style(9): sort got-build-regress.sh getopts cases; ok stsp


style(9) whitespace: don't indent got-build-regress.sh cases ok stsp@


util/got-build-regress.sh: add missing 'W' to optstring ok stsp@


tog: don't clobber error with got_repo_close() error While here, style(9) the adjacent block: remove function call from initializer. ok stsp@


tog: clamp selected idx to avoid showing negative indexes In the rare case views are smaller in height than the first line number after the view's header lines (i.e., [2,5] depending on the view), we can decrement the selected entry index into negative values; clamp it to 0. Add a log view test case covering this path by opening a child tree view and toggling fullscreen. ok stsp@


fix NULL deref when scrolling small tog tree views down In the rare case a tree view is smaller than four lines in height, the last_displayed_entry is NULL. Check this condition on a scroll down event with j/down arrow or ^f/pgdn to guard a NULL got_tree_entry from being passed to got_tree_entry_get_next() where it is dereferenced. And add a test case covering this path. ok stsp@


tog: don't mark incorrect base commit in nested log views If a nested log view is opened, don't reuse the work tree's base commit index from the initial `tog log` invocation because it is based on the initial commit queue. If it has become invalid, an incorrect log view commit entry is painted with the base commit marker. Reset the index whenever opening nested log views so that it is recomputed, and write a regression test to cover this case. ok stsp@


regress/tog: ref view coverage of tag references Test for the error case when selecting tags that point to non-commit objects. And test the valid case of selecting nested tags that resolve to commit objects. ok stsp@