Commits
- Commit:
df610f472695eeed6f3a618d1833f17f767e9ed1
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix memory leak introduced in d927f8c
ok tracey@
- Commit:
f57ea9f3db923c517242dcf1eed8948a71d8a67c
- From:
- Josh Rickmar <jrick@zettaport.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
don't create signed tag objects with trailing NUL
Although Git itself did not care, the superfluous NUL at the end of
the tag object was breaking GitHub's SSH signature detection.
ok stsp@
- Commit:
75716fd6ed1a99a0e601b2820363b17d7c0333a7
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: sockets: handle sa_len/ss_len portably
In the sockaddr_storage struct, there can be a ss_len field. This is
seen on some BSDs, but not Linux. Since this isn't POSIX-specific,
there's no guarantee it will be available on all systems.
- Commit:
0b75e088e5e7799559ddc81934e9d06c29f10c5b
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: add CSP policy
ok tracey@
- Commit:
ddf2e5c25df6ac585a7908b50cc996d14f90eb2f
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: fix for possible NULL beign passed to fcgi_printf
reported by and ok tracey@
- Commit:
255f40228747f0671ce214c468858d83c2efe8a5
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: make sure to escape possibly unsafe strings
this fixes only the HTML escaping of strings, the urlencode is still
missig.
while here also plug a memory leak in gotweb_render_branches and drop
some needless ternary operators.
ok tracey@
- Commit:
0b3823fddac066935c55c29fba27822c4b70ddce
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: minor tweaks to the generated HTML
spotted by validator.w3.org:
- use target="_blank" instead of `_sotd'
- drop `alt' attributes in `a' tags
This fixes all the errors reported; only a warning suggesting to add a
`lang' attribute on the <html> tag remains.
- Commit:
1f6ec0684239b7d7a1b63040f34db7d348fe5cb7
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
mark functions internally used by sockets.c as static
ok tracey
- Commit:
c19738c9ed1553d21d6acaecb58a6fa9d966b63b
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix previous: store port number in host byte order, convert for struct sockaddr
With the previous patch the listen port was correct, but the debug log output
was still displaying the swapped port number. Now both listen behaviour and
debug log output agree.
- Commit:
1e135a4fe7efe6b6560f851452a7224c7b361427
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix gotwebd default fcgi listen port byte-order (port 10275 -> port 9000)
ok tracey
- Commit:
a90e31174c5788d5225bd2c2363056b86f670c42
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: listen on localhost only by default
ok tracey
- Commit:
9d7714e36f114695b3a1737360a6ef12b361860d
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: struct socket_conf can only use a single address, so don't use a list
ok tracey
- Commit:
7939347171a791b258516ee7ce589dc403328c78
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: add fcgi_printf
instead of fcgi_gen_response which outputs only a fixed strings provide
a printf-like fcgi_printf: it greatly simplifies the generation of the
HTML pages.
While here also (probably) fix some HTML errors: the output was verified
with the W3C validator and it's correct (in the sense that the tags are
properly closed, there are still some other things the validator
complains about.)
ok/encouragement baseprime@, ok jamsek
Thanks for reading such a boring diff!
- Commit:
4b553fec9a9b5b083e5b564787f948254a2dde29
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: configure: fix version string
Older autotools versions need extra coaxing when running external
programs.
- Commit:
6efd5dc99c4e43f7bd6b93d78660734afbc78bbb
- From:
- Thomas Adam <thomas@xteddy.org>
- Date:
portable: ver: fix incorrect envvar
- Commit:
b5c076278bbb7205a9828d2ac2da41999fff4a14
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix overflow in blame callback
spotted by noticing gotwebd crashing on some blame requests.
Diff from stsp@ with a fix from tracey@, I'm committing it only because
he is short on time.
ok stsp@
- Commit:
720c2b0511f6dbff9e2bf529e474143ca8617731
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: initialize IPv4 and IPv6 sockets in the same way
ok tracey
- Commit:
ae46fc5c450cfed441d1a5eca6df1881785fb236
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: don't listen on FCGI sockets when FCGI is not enabled
ok tracey
- Commit:
90d63d4711e9554b6e7e6e26d2fbeb50964452cf
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: do not allocate server/socket list heads separately
ok millert@
- Commit:
62f852145bf61e3ed9b42f7a00cd7cd0b5ff8835
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
gotwebd: do not allocate address list heads separately, this is unnecessary
ok millert@
- Commit:
717a78d4f87c3704afe34c77e211349932575d5b
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
fix snprintf error handling
follow the "proper secure idiom" described in the CAVEATS section of
printf(3). reminded by tb@ and millert@
- Commit:
406d5a24d29a81e1741aed65acc1f1000c44f0d3
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
convert two snprintf to strlcpy
"looks good to me" millert@
- Commit:
7e1f3a3d0f07de14dd5caeb7dd7b3a802afe3723
- From:
- Omar Polo <op@omarpolo.com>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
check for fprintf failure
- Commit:
b6bfeb85557195c11514ad96b30ce83da839b708
- From:
- Josiah Frentsos <jfrent@tilde.team>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
got(1): Replace 'Ar sign' with 'Cm sign'
Cm sign matches the markup used in the ssh-keygen(1) man page.
Patch by Josiah Frentsos
- Commit:
8c88ec70002d593f9832cffcde85a6ae1c7fd65e
- From:
- Stefan Sperling <stsp@stsp.name>
- Via:
- Thomas Adam <thomas@xteddy.org>
- Date:
regress: adjust expected usage output in "revert_no_arguments" test